Mindustry icon indicating copy to clipboard operation
Mindustry copied to clipboard

Made unitcap variable for logic

Open JasonP01 opened this issue 8 months ago • 3 comments

Made logic @unitcap global variable, this allows processors to access their team's unitcap amount.

Begon the awful current ucap counting methods

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • [x] I have read the contribution guidelines.
  • [x] I have ensured that my code compiles, if applicable.
  • [x] I have ensured that any new features in this PR function correctly in-game, if applicable.

JasonP01 avatar Apr 20 '25 10:04 JasonP01

The one in LAssembler might be useless. And the bundle might need better wording. Id rather leave the bundle to the merger

JasonP01 avatar Apr 20 '25 17:04 JasonP01

This is very inefficient. I will not accept a solution that injects a variable into the processor and uses getVar to dynamically update it every frame for every processor. Retaining an instance to the underlying LAssembler is also unacceptable.

Anuken avatar Apr 20 '25 19:04 Anuken

Mightve overreacted. But point remains the same. I can not solve the issue, i spent 6 hours trying and could not.

If you (anuke) wont accept the current state or fix it yourself you can freely deny this pr.

I wont try and fix the issues you stated.

JasonP01 avatar Apr 21 '25 14:04 JasonP01