Mindustry icon indicating copy to clipboard operation
Mindustry copied to clipboard

Slag Incinerator Rework: No Slag Consumption Rate

Open SomeonesShade opened this issue 1 year ago • 5 comments

Implements https://github.com/Anuken/Mindustry-Suggestions/issues/5210 Specifically A1, "Input Slag Once/No Slag Consumption Rate"

Details: Set Slag Incinerator Consumption rate to: 0f Removed /sec in Liquid Display if amount is 0f

Slag Incinerator in Action: Screenshot 2024-09-10 131751 Video:

https://github.com/user-attachments/assets/a3ab3925-ae33-4d9b-b031-5a944734155e

Liquid Display Fix: image Before: Screenshot 2024-09-10 130848

Seems to be well supported by the discord: https://discord.com/channels/391020510269669376/766777428097105920/127977327314351317 and has already been reviewed at #balancing

Suggestion Alternative B: "Slag Producing Slag Incinerator" might be chosen instead if implementation is possible, if I'm in a position to do it myself, although priority is getting something working/non-controversial first, then follow up if it has support.

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • [x] I have read the contribution guidelines.
  • [x] I have ensured that my code compiles, if applicable.
  • [x] I have ensured that any new features in this PR function correctly in-game, if applicable.

SomeonesShade avatar Sep 10 '24 10:09 SomeonesShade

how did the check fail for a one line change….

SomeonesShade avatar Sep 10 '24 13:09 SomeonesShade

wait I can probably remove the /sec slag and call it a day

SomeonesShade avatar Sep 10 '24 13:09 SomeonesShade

how did the check fail for a one line change….

Cause its a workflow issue, anuke needs to update dependacies

JasonP01 avatar Sep 10 '24 14:09 JasonP01

Fixed the liquid Display thing, seems complete now Should be the last commit, hopefully

SomeonesShade avatar Sep 11 '24 08:09 SomeonesShade

my first merge conflict and it somehow caused the pr to close ... yay

SomeonesShade avatar Sep 30 '24 13:09 SomeonesShade

Omg!?

JasonP01 avatar Oct 04 '24 20:10 JasonP01