Anubis icon indicating copy to clipboard operation
Anubis copied to clipboard

CHG convert api typing to py3.10 standards

Open wabscale opened this issue 4 years ago • 5 comments

There are a bunch of things that have changed with type annotations in python 3.10 that we should move the api to. These changes primarily involve things like using list instead of typing.List and dict instead of typing.Dict.

We don't need to do this all at once. We can do one file or one module at a time.

https://docs.python.org/3/library/typing.html

wabscale avatar Mar 26 '22 02:03 wabscale

Hi @wabscale! I would like to take this issue up.

sp6370 avatar Apr 11 '22 01:04 sp6370

Sure. I already did a lot of it with just doing find and replace, but I'm sure I missed things. Let me know if you have any questions

wabscale avatar Apr 11 '22 04:04 wabscale

Sure. I already did a lot of it with just doing find and replace, but I'm sure I missed things. Let me know if you have any questions

I am trying to set up the dev environment on my M1 mac. I am running into issues with python. I am trying to launch the project using the make file, however, the API server is not getting started.

How can I check if the virtual environment required for API is getting set up?

image

sp6370 avatar Apr 13 '22 00:04 sp6370

This is probably because the virtualenv for the api did not full initialize correctly. You can go to the api directory and do rm -rf venv && make venv to re-create it.

wabscale avatar Apr 15 '22 00:04 wabscale

@ravitejasssihl you can get started with this one.

wabscale avatar Sep 10 '22 13:09 wabscale

@wabscale @sp6370 this looks like its mostly finished ,all are replaced ,is there someting am missing?

ravitejasssihl avatar Oct 17 '22 16:10 ravitejasssihl

Yeah this is pretty much done. Please do not @ jepst randomly, he is a professor that uses Anubis and does not participate in development.

wabscale avatar Oct 17 '22 16:10 wabscale

Hai @wabscale .You missed at utils.py in api/tests folder ,I have added it there.I have also put a pull request ,please check.

ravitejasssihl avatar Oct 17 '22 18:10 ravitejasssihl