rust-amqp icon indicating copy to clipboard operation
rust-amqp copied to clipboard

Published 20 hours ago • verified publisher icon Antti

Upgrade to the latest openssl

Open alex opened this issue 6 years ago • 4 comments

The version of openssl that was previously used had numerous security issues, and did not support the latest versions of the upstream openssl package.

I wasn't sure what to do about the impl Clone on connection, there doesn't appear to be a way to get the current behavior with SslStream in the latest version of openssl.

alex avatar Jan 05 '19 23:01 alex

Relevant to #58

Shnatsel avatar Jan 05 '19 23:01 Shnatsel

LGTM 👍

dizda avatar Jan 15 '19 11:01 dizda

This doesn't really upgrade to the latest openssl, as adding panic makes it TLS mode completely non-functional. I removed tls feature from the list of default features, this should make it easier to use this crate when the tls (openssl) feature is not required.

Antti avatar Jan 24 '19 15:01 Antti

Hmm, unfortunately I don't believe it's possible to emulate the Clone API with a recent OpenSSL, except perhaps by making it an Rc (or maybe Arc or Mutex + Arc). Do you have an opinion on how to proceed?

alex avatar Jan 24 '19 15:01 alex