OnlyV icon indicating copy to clipboard operation
OnlyV copied to clipboard

Full book name option has sometimes longname

Open tomtailor1983 opened this issue 5 years ago • 8 comments

  • Start OnlyV (ePub: Germany, Bible 2013)
  • Choose a text in: 1. Mose or Psalm
  • OnlyV will generates: 1.Mose (Genesis) 2:2 or Psalmen 119:1
  • Correct would be: 1. Mose 2:2 or Psalm 119:1

tomtailor1983 avatar May 08 '19 06:05 tomtailor1983

@tomtailor1983 The full names of books are extracted from the Bible contents page in the epub, so simply appear in OnlyV as they are listed.

AntonyCorbett avatar May 08 '19 07:05 AntonyCorbett

Ok, but I think it could still be a bug. :) The psalm, for example, appears in the plural. Here are two examples:

grafik

grafik

Thank you, Antony!

tomtailor1983 avatar May 12 '19 10:05 tomtailor1983

@tomtailor1983 Thanks, but as I said, the names of the books are simply extracted from the epub contents page. So the book titles for the above are "Psalmen" and "Mose (Genesis)". OnlyV uses the book name followed by chapter and verse. If this is inappropriate in the German language (as appears to be the case), then we need to find the correct title formulation somewhere in the epub.

AntonyCorbett avatar May 12 '19 13:05 AntonyCorbett

Yes, that's what I mean. Maybe we can pull the title somewhere else from the epub. Thank you!

tomtailor1983 avatar May 12 '19 14:05 tomtailor1983

On the other hand, isn't the epub sourced from the Branch? I would think you should contact them for clarification. They'll either thank you for finding an error, or explain why it is correct.


From: tomtailor1983 [email protected] Sent: Sunday, May 12, 2019 10:27 AM To: AntonyCorbett/OnlyV Cc: Subscribed Subject: Re: [AntonyCorbett/OnlyV] Full book name option has sometimes longname (#27)

Yes, that's what I mean. Maybe we can pull the title somewhere else from the epub. Thank you!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAntonyCorbett%2FOnlyV%2Fissues%2F27%23issuecomment-491600546&data=02%7C01%7C%7C435e298024e041ca7d7108d6d6e6041e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932680724477644&sdata=9P1bDUJZjIuQLcpM%2Fvm8wCcgR7I%2Fm82HkdPJZo6hWTc%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAINW6PNMWMFIC35HAUE52VDPVASOPANCNFSM4HLOWNEQ&data=02%7C01%7C%7C435e298024e041ca7d7108d6d6e6041e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932680724487655&sdata=%2BaIuc%2FrkxKHSHGoJu5xZxW8O73PfF5w%2B5OimG%2FR0xbg%3D&reserved=0.

richfrantz avatar May 12 '19 15:05 richfrantz

@richfrantz I think @tomtailor1983 is right. The subtlety is only clearly exposed in non-English languages. However, we have one example in English - “Psalms” is the name of the book, but when we make reference to a verse it is more correctly “Psalm x:y”. No one has complained that OnlyV renders it “Psalms x:y” because we commonly use that formulation too. But I guess in German the use of the plural in this context is quite jarring.

AntonyCorbett avatar May 12 '19 16:05 AntonyCorbett

I agree. My point is that if you are getting your data from the epub, the epub might have a bug. If you go to wol.jw.org and switch to German, the Bible book is Psalmen, plural, but click inside and it reverts to the singular, Psalm.

Rich Frantz


From: Antony Corbett [email protected] Sent: Sunday, May 12, 2019 9:09:41 AM To: AntonyCorbett/OnlyV Cc: richfrantz; Mention Subject: Re: [AntonyCorbett/OnlyV] Full book name option has sometimes longname (#27)

@richfrantzhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frichfrantz&data=02%7C01%7C%7Ce9681a338a0a4a2c206b08d6d6f43e61%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932741831474237&sdata=0E1x3Grm1sP1jdroco%2FPpHqFHcM6OaIpEe0l48smQqY%3D&reserved=0 I think @tomtailor1983https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftomtailor1983&data=02%7C01%7C%7Ce9681a338a0a4a2c206b08d6d6f43e61%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932741831484248&sdata=I232fnpLsYe0%2B%2BaoFGDvibz6IeAuw09ycvTIGjyCqNQ%3D&reserved=0 is right. The subtlety is only clearly exposed in non-English languages. However, we have one example in English - “Psalms” is the name of the book, but when we make reference to a verse it is more correctly “Psalm x:y”. No one has complained that OnlyV renders it “Psalms x:y” because we commonly use that formulation too. But I guess in German the use of the plural in this context is quite jarring.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAntonyCorbett%2FOnlyV%2Fissues%2F27%23issuecomment-491608383&data=02%7C01%7C%7Ce9681a338a0a4a2c206b08d6d6f43e61%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932741831494253&sdata=CYdR4G1RZXI6KE%2FuBgsat3j8BSecl6dRxIoO2diLxOY%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAINW6PI3IXDH2IPCSQ6CL7TPVA6MLANCNFSM4HLOWNEQ&data=02%7C01%7C%7Ce9681a338a0a4a2c206b08d6d6f43e61%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932741831504258&sdata=%2BTFAOQurI8QE4Y5Wd09AYU8wxxgQv2HIxhk4GdUrc1c%3D&reserved=0.

richfrantz avatar May 12 '19 18:05 richfrantz

Hi, is possible to add the ability to edit the book name as we are allow verse editing please? Thank you so much for your great work,

malexarc avatar Jan 17 '21 03:01 malexarc