Convolutional-KANs icon indicating copy to clipboard operation
Convolutional-KANs copied to clipboard

Nit: Relative imports of KANConv script

Open ubitquitin opened this issue 9 months ago • 1 comments

Hi! Great work and really excited to play around with this library.

When I cloned the repo and tried following the sample code (or rerunning the ipython file) I noticed that without importing a certain file the other file imports (or any file utilizing KAN_Conv.py/KAN_Linear.py) would fail due to ModuleNotFound errors. image Looks like that's because the file appends the sub and sub-sub directories to the sys path here.

Wondering if it might be easier to adjust the base KAN_Conv/KAN_Linear python script imports so that there isnt a dependency on this sys path in that specific file?

Changing this to something like this:

import math
from kan_convolutional.KANLinear import KANLinear
from kan_convolutional import convolution

got the imports working for me.

Happy to open a PR and I want to dive into the models further, but wanted to check first that I'm not missing any context.

ubitquitin avatar May 23 '24 04:05 ubitquitin