Antonin Jousson
Antonin Jousson
Hi. Is there any chance this gets merged soon? Is this blocked only by testing? If that’s the case, I can maybe help.
Hi @danielbellhv, Soda SQL will soon be deprecated in favor of [Soda Core](https://github.com/sodadata/soda-core). It seems to me your issue is actually related to Soda Core rather than to Soda SQL....
@tombaeyens , I don't think the change you suggest would work since `has_numeric_values` (or `is_numeric`) is actually the same thing as what is already there, i.e `scan_column.is_number or scan_column.is_column_numeric_text_format`. I...
The other way around, it looks like we currently compute top 5 min and max values on all columns. Wouldn't it make more sense to only compute those on numeric...
I have the same understanding of the current state and required changes as @dirkgroenen. Point 2 has actually already been handled in https://github.com/sodadata/soda-sql/commit/84e6d3254550f581cbd64faede5be7c3c9992998, so I'll take care of point 1...
Hi @paulskipprhudson, Soda SQL will soon be deprecated in favor of [Soda Core](https://github.com/sodadata/soda-core). It seems to me your issue is actually related to Soda Core rather than to Soda SQL....