vacances-scolaires-france icon indicating copy to clipboard operation
vacances-scolaires-france copied to clipboard

Published 20 hours ago • verified publisher icon AntoineAugusti

Data can be downloaded directly from data.gouv.fr/

Open vinraspa opened this issue 2 years ago • 2 comments

I use vacances-scolaires-france inside an app that is bundled with PyInstaller. So I need data to be refreshed from year to year without updating vacances-scolaires-france module. I added the possibility to ask for download the most recent data when the main class is initialized. These modifications are backward compatible as reading from data/data.csv is kept as the default behavior.

vinraspa avatar Jun 13 '22 09:06 vinraspa

~~I have no idea what the problem is with test-latest...~~ See this: https://github.com/xlcnd/isbnlib/issues/95 (Nose is incompatible with Python >= 3.10)

vinraspa avatar Jun 13 '22 09:06 vinraspa

If this new feature is OK, I will create a new cleaner PR with an only one commit. Otherwise, we can imagine not to deal with the download part of the job and just give the user the opportunity to supply their own csv file (requests module will ne be necessary anymore)

vinraspa avatar Jun 13 '22 10:06 vinraspa