ngx-linkifyjs icon indicating copy to clipboard operation
ngx-linkifyjs copied to clipboard

Incomplete interface for validate in NgxLinkifyOptions

Open teolag opened this issue 5 years ago • 1 comments

The interface for validate in NgxLinkifyOptions is incomplete. https://github.com/AnthonyNahas/ngx-linkifyjs/blob/254d6d682189fc8d0787e3644d0a0119f90dcc42/src/module/interfaces/ngx-linkifyjs.interface.ts#L21

According to linkifyjs the validate attribute could be a boolean, function or an object https://soapbox.github.io/linkifyjs/docs/options.html#validate

When I set validate to a function the linter typescript warns me I'm using the wrong type. If I set the function as any, everything works fine. So the code accepts an function but the interface does not

teolag avatar Oct 28 '19 08:10 teolag

I would appreciate a PR from you🍻

AnthonyNahas avatar Oct 28 '19 09:10 AnthonyNahas