ngx-auth-firebaseui icon indicating copy to clipboard operation
ngx-auth-firebaseui copied to clipboard

FR: Update for Angular 10

Open rhofour opened this issue 4 years ago • 4 comments

I tried using this project in an Angular 10 one and I'm getting the following error:

    node_modules/ngx-auth-firebaseui/lib/ngx-auth-firebaseui.module.d.ts:22:132 - error TS2314: Generic type 'ModuleWithProviders<T>' requires 1 type argument(s).
    
    22     static forRoot(configFactory: FirebaseAppConfig, appNameFactory?: () => string | undefined, config?: NgxAuthFirebaseUIConfig): ModuleWithProviders;

This appears to be related to ModuleWithProviders change in Angular 10.

I'm not sure what else is needed to make this compatible with Angular 10.

rhofour avatar Jul 02 '20 15:07 rhofour

I fixed the issue by adding the following in packages.json

"scripts": {
    "postinstall": "ngcc"
  },

https://angular.io/guide/migration-module-with-providers https://angular.io/guide/glossary#ngcc https://angular.io/guide/glossary#ivy

If you use rxjs Subject you might encounter this issue. https://stackoverflow.com/questions/62812510/subject-instantiation-error-in-angular-10

vella-nicholas avatar Jul 15 '20 14:07 vella-nicholas

Tried to install it in the project with Angular 10 and fresh @angular/fire and got lots of inconsistent package errors.

npm WARN deprecated [email protected]: AngularFire has moved, we're now @angular/fire
npm WARN [email protected] requires a peer of inquirer@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/common@^2.2.3 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/core@^2.2.3 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of rxjs@^5.0.1 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of zone.js@^0.7.2 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/core@>=5.0.0 <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/common@>=5.0.0 <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/core@>=5.0.0 <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/common@>=5.0.0 <7.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of rxjs@^5.5.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/[email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/common@>=6.0.0 <9 || ^9.0.0-0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/core@>=6.0.0 <9 || ^9.0.0-0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/platform-browser@>=6.0.0 <9 || ^9.0.0-0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular/[email protected] requires a peer of @angular/platform-browser-dynamic@>=6.0.0 <9 || ^9.0.0-0 but none is installed. You must install peer dependencies yourself.

Looks like ngx-auth-firebaseui should be improved to be compatible with Angular 10.

dobromyslov avatar Jul 28 '20 00:07 dobromyslov

Any plans for upgrading to Angular 10 and new Material Design?

Kamil7S avatar Aug 03 '20 07:08 Kamil7S

The library is updated and now works with V11 of Angular. Can we go ahead and mark this as resolved? @AnthonyNahas

DavidTheProgrammer avatar Dec 07 '20 18:12 DavidTheProgrammer