antennapod.github.io icon indicating copy to clipboard operation
antennapod.github.io copied to clipboard

Upgrade to Bootstrap 5.3+

Open keunes opened this issue 3 years ago • 5 comments

Short description: Upgrade Bootstrap to version 5.3 or later, when it is released.

Location:

Why have this: It 'natively' supports Dark mode 🎉 This will decrease the need for custom CSS. And it will undoubtedly bring other improvements as well.

More info: https://github.com/twbs/bootstrap/pull/35857#issuecomment-1330196729

keunes avatar Nov 29 '22 18:11 keunes

Also, building now gives these warning messages because of the outdated bootstrap:

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($spacer, 2) or calc($spacer / 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
717 │ $navbar-padding-y:                  $spacer / 2 !default;
    │                                     ^^^^^^^^^^^
    ╵
    .../antennapod.github.io/_sass/bootstrap/_variables.scss 717:37  @import
    bootstrap/bootstrap.scss 9:9                                                               @import
    .../antennapod.github.io/assets/css/main.scss 4:9                root stylesheet

ByteHamster avatar Jan 14 '23 13:01 ByteHamster

Another advantage is the removal of jQuery dependency. For custom code this can be done upfront. Reference: https://getbootstrap.com/docs/5.3/migration/#dependencies

Rotzbua avatar Jul 26 '23 13:07 Rotzbua

Hi @Rotzbua, With #203 done, are we ready to start working on this? (If yes, I'm wondering how to approach this. Maybe we should see if we can drop more custom CSS? Also, would you be up for a call to discuss the site/this upgrade in person?)

keunes avatar Sep 02 '23 04:09 keunes

Hi @Rotzbua, kind reminder. Are you interested in working in this? I would love to work on this and get this done :-) (if no time or interest, please don't hesitate to mention that also)

keunes avatar Dec 04 '23 21:12 keunes

@keunes I will have a look around Christmas and new year

Rotzbua avatar Dec 19 '23 20:12 Rotzbua