Antares_Simulator icon indicating copy to clipboard operation
Antares_Simulator copied to clipboard

Expression visitors : first implementation

Open flomnes opened this issue 6 months ago • 1 comments

TODO

  • [ ] Add missing object types
  • [ ] Add missing visitors
  • [x] Re-organize source files / split header/source, use the usual hierarchy with include/XXX/, define visitor / node types separately, etc.
  • [x] Deep copy for nodes (copy operator/constructor is currently deleted because of std::unique_ptr)
  • [ ] private children for nodes ?
  • [ ] Use a generic type to avoid defining ~14 object types manually ?
  • [ ] Sonar issues
  • [ ] Separate tests (move existing calls to test, add more tests)

~~The following causes a double free because of two std::unique_ptr holding the same memory address~~

Parameter* p = new Parameter(1.);
Add(p, p);

flomnes avatar Jul 31 '24 08:07 flomnes