simulation.start correction is confusing

[flomnes]

See src/libs/antares/study/parameters.cpp

if (key == "simulation.start")
{
    uint day;
    if (not value.to(day))
        return false;
    if (day == 0)
        day = 1;
    else
    {
        if (day > 365)
            day = 365;
        --day;
    }
    d.simulationDays.first = day;
    return true;
}

In particular, we have

• If simulation.start = 0 , then d.simulationDays.first = 1
• If simulation.start = 1 (default), then d.simulationDays.first = 0