fasthtml icon indicating copy to clipboard operation
fasthtml copied to clipboard

Adding mermaidJS for mermaid graphs

Open ImtiazKhanDS opened this issue 1 year ago • 2 comments

name: Pull Request for adding Mermaid Graphs

about: Propose changes to the codebase title: 'Add Mermaid graphs in fasthtml websites.' labels: 'graphs' assignees: 'Jeremy'


Related Issue Please link to the issue that this pull request addresses. If there isn't one, please create an issue first.

Proposed Changes Describe the big picture of your changes here. If it fixes a bug or resolves a feature request, be sure to link to that issue. mermaid_graph

Types of changes What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist Go over all the following points, and put an x in all the boxes that apply:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information Any additional information, configuration or data that might be necessary to reproduce the issue.

ImtiazKhanDS avatar Oct 13 '24 18:10 ImtiazKhanDS

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/518

gitnotebooks[bot] avatar Oct 13 '24 18:10 gitnotebooks[bot]

@ImtiazKhanDS Thanks for submitting this PR, I've added to my blog and given you credit:

  • https://daniel.feldroy.com/posts/mermaid-charts
  • https://github.com/pydanny/daniel-blog-fasthtml/commit/d3d237d485841422bb2c7ae8e3bae7a306bb35c8

pydanny avatar Oct 14 '24 09:10 pydanny

JupyUvi doesn't work in the docs unfortunately. So you might just need to use markdown to describe how to use it. Also don't forget to nbdev_export.

jph00 avatar Oct 15 '24 20:10 jph00

JupyUvi doesn't work in the docs unfortunately. So you might just need to use markdown to describe how to use it. Also don't forget to nbdev_export.

JupyUvi doesn't work in the docs unfortunately. So you might just need to use markdown to describe how to use it. Also don't forget to nbdev_export.

Got it , did the changes.

ImtiazKhanDS avatar Oct 16 '24 07:10 ImtiazKhanDS

@ImtiazKhanDS there's no change to the .py file in your PR. I think you forgot to add #| export to the cells you want to export?

jph00 avatar Oct 16 '24 18:10 jph00

@ImtiazKhanDS there's no change to the .py file in your PR. I think you forgot to add #| export to the cells you want to export?

Sorry for the trouble, now added.

ImtiazKhanDS avatar Oct 17 '24 06:10 ImtiazKhanDS

Good job! :D

jph00 avatar Oct 19 '24 05:10 jph00