fasthtml icon indicating copy to clipboard operation
fasthtml copied to clipboard

Add status codes when missing from exception handlers

Open pydanny opened this issue 5 months ago • 1 comments


name: Pull Request about: Propose changes to the codebase title: '[PR] Add status codes when missing from exception handlers' labels: 'enhancement' assignees: ''


Proposed Changes

When exception_handlers don't specify a status_code in the returned Response, this will add it for them from the specified exception_handlers.

Types of changes What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist Go over all the following points, and put an x in all the boxes that apply:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [x] I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information

Inspired by this code, which I added after it was pointed out that my 404 pages didn't return 404 status codes: https://github.com/pydanny/daniel-blog-fasthtml/blob/main/main.py#L24-L38

pydanny avatar Sep 24 '24 10:09 pydanny