fasthtml icon indicating copy to clipboard operation
fasthtml copied to clipboard

Document the MiniDataAPI Specification

Open pydanny opened this issue 1 year ago • 1 comments

  • [x] Add contains explanation
  • [x] Improve xtra docs
  • [x] transform is a kw argument in db.create that performs necessary data structure migrations, but not data migrations. It isn't working. See https://github.com/AnswerDotAI/fastlite/issues/21
  • [x] __call__ takes a where clause, so that is dependant on the DB implementation
  • [x] __call__ takes a limit
  • [x] __call__ takes an offset

pydanny avatar Aug 14 '24 03:08 pydanny

Found 1 changed notebook. Review the changes at https://gitnotebooks.com/AnswerDotAI/fasthtml/pull/294

gitnotebooks[bot] avatar Aug 14 '24 03:08 gitnotebooks[bot]

@pydanny also note that you would not be able to change the username on a to-do when xtra is in effect. Also, it's a little confusing IMO that the doc refers to .contains, but that's not a method we define. Maybe say in? (and maybe also note that this behavior is automatic in Python as long as you have defined __getitem__?)

jph00 avatar Sep 19 '24 17:09 jph00

@pydanny do you think this is ready to merge now?

jph00 avatar Sep 20 '24 22:09 jph00

@jph00 Barring your suggested change to `xtra| i think it is ready for merge. 🙂

pydanny avatar Sep 21 '24 07:09 pydanny

@jph00 I think this is ready to merge. Any other changes you think should go in?

pydanny avatar Sep 24 '24 16:09 pydanny

Excellent! Many thanks! :D

jph00 avatar Sep 24 '24 17:09 jph00