tch-nginx-gui icon indicating copy to clipboard operation
tch-nginx-gui copied to clipboard

Published 20 hours ago • verified publisher icon Ansuel

Asterisk Manager

Open Suifu opened this issue 5 years ago • 11 comments

Based on 558 Asterisk Manager needs some care, but the wiki part seems to be fine (GitHub doesn't support pull requests for the wiki repository, only the main repository) example. Regard

Suifu avatar Mar 13 '19 21:03 Suifu

Could you please allow modifications so this PR can be modified?

kevdagoat avatar Mar 13 '19 23:03 kevdagoat

Would like to fix some English

kevdagoat avatar Mar 13 '19 23:03 kevdagoat

@Ansuel

Ghost9090 avatar Mar 14 '19 22:03 Ghost9090

I see better splitting this in 2 PR as asterisk and the wiki are totally different things

FrancYescO avatar Mar 17 '19 10:03 FrancYescO

Hello thank to all for the interest, FrancYescO i don't think the division is needful because the tab is not seen if there is no asterisk (however the commits concerned are e6855fa and 19eb209). Thanks to kevdagoat for correct my misspelling (some are really stupid), only one thing: into 42b9f6c are you sure that is correct to remove line 26 (Wait WITHOUT TURNING OFF). Regard

Suifu avatar Mar 19 '19 10:03 Suifu

about asterisk we can also add it as an extension app and the modal will be placed only when installed

FrancYescO avatar Mar 19 '19 10:03 FrancYescO

can be useful for the wiki: https://github.com/dirkfeytons/transformer/wiki

FrancYescO avatar Mar 20 '19 11:03 FrancYescO

FrancYescO > about asterisk we can also add it as an extension app and the modal will be placed only when installed Yes, this is a good idea, i have only touched voice for now FrancYescO > can be useful for the wiki: https://github.com/dirkfeytons/transformer/wiki Yes, we can add a "technical section" that explains how the various parts work, there are other useful Repositories inside dirkfeytons. Thanks for the report.

Suifu avatar Mar 21 '19 11:03 Suifu

@suifu create PR for this asterisk manager

Ghost9090 avatar May 15 '19 00:05 Ghost9090

PR is already opened.

FrancYescO avatar May 15 '19 06:05 FrancYescO

English version: I was expecting a confirmation from Ansuel before making changes, need to know if it worked correctly. Meanwhile i split the wiki part. Asterisk manager pull for now is this. Regard Italian version: Aspettavo una conferma da Ansuel prima di aplicare modifiche al menu e sopprattutto sapere se funziona tutto correttamente, intanto ho fatto un altro pull con la parte wiki. Per ora asterisk manager è qua. Saluti

Suifu avatar May 17 '19 15:05 Suifu