Christian Marangi

Results 691 comments of Christian Marangi

@robimarko qm afaik is what handle all the buffer and detects any error

> Well, the code is quite nasty: > > https://github.com/openwrt/openwrt/blob/fd7d318bc732158605d05abd0e661adf07ccb822/target/linux/ipq40xx/files/drivers/net/dsa/qca8k-ipq40xx.c#L1551 > > I still haven't figured out what is it really meant to do, I see that it's poking directly...

@robimarko yes that is my implementation i just put the qm check in the phylink change link all the 1g and 100m stuff i put in the dedicated phy driver...

I honestly think that a helper and putting the correct function in some struct would be the best way to do it. So your idea is to move everything to...

@Leo-PL Since it's really a quirk and you are introducing a specific value wonder if directly changing the value would work anyway without using local variables... (i mean the speed...

I still have to understand this better but to me it seems strange that this is needed considering we have a fixed-link node

Problem is that dsa introduce some perf regression and require more community presence to fix them and people gets angry with perf regression... So we are a bit stuck. Il...

@castillofrancodamian dsa is doable... problem is perf regression due to the use of tagging...

Mhhh don't know about backporting this...

@castiel652 it's practically not widely tested. Don't know if it would be a good idea to backport it even if we use ath10k-ct by default