Anselm Hahn
Anselm Hahn
Sorry, @neersighted ~~it seems to be that the rebase of my PR to the current main wasn't successful.~~ Looks better! It might a good idea to add `mypy-module` to https://github.com/python-poetry/poetry-core/blob/main/.pre-commit-config.yaml...
In case of a permanent check of possible refactors, you can actually use https://github.com/sourcery-ai/sourcery as part of the **CI/CD**. ```yaml ignore: ["src/poetry/core/_vendor"] refactor: skip: ["extract-method"] python_version: '3.7' ```
> The changes in [e932cda](https://github.com/python-poetry/poetry-core/commit/e932cdab157189088b357849f080850d5e457feb) make things worse, not better. > > The type signatures were correct before, and scattering `Any` all over the place simply makes them less useful....
> I don't understand your point. That's exactly the current implementation on master, and it typechecks just fine without an `Any` annotation? Indeed, it's a little bit wired ... https://github.com/python-poetry/poetry-core/pull/279/commits/6e3cf6fc039cc3c88edd06e3e674a0cde65f5630...
> As I say, I think that mypy has a special case for `NotImplemented` and the refactoring has disturbed the balance. > > Suggest just put that code back as...
@neersighted can you take a look later, please?
See also: https://github.com/keras-team/autokeras/blob/master/autokeras/utils/utils.py#L87
> Thanks for the PR! However, we prefer to keep the current simple bibtex for now until the cff files are widely adopted in popular repos. It might be an...
See also: #1734
> Thanks for the fix! > > If history is None, it should trigger [this error](https://github.com/keras-team/keras-tuner/blob/master/keras_tuner/engine/tuner_utils.py#L283). To your test, does it trigger it? We can first add a `if` to...