AnomalRoil
AnomalRoil
Currently our mainnet nodes have a ``` Period = "30s" CatchupPeriod = "15s" ``` The default testnet has ``` Period = "25s" CatchupPeriod = "15s" ``` The unchained-3s testnet has:...
It often hangs while stopping the nodes, and stops responding. A quick fix in #1158 was to spin go routines to stop each node, but that still sometimes hangs, it...
It seems we potentially have a race here if people are changing the logs too often for their verifying client. This is currently only used in our constructors without concurrency,...
idx, _ := key.Scheme.IndexOf(p.GetPartialSig()) idx, _ := h.crypto.ThresholdScheme.IndexOf(p.GetPartialSig()) Should the error here be ignored? https://github.com/drand/drand/pull/1103#discussion_r1088012283 And also in node_test.go: https://github.com/drand/drand/pull/1103#discussion_r1088014229
Let us use `require` in tests and avoid panics that are not needed. We should review all panic calls and decide if they are necessary or not. Also: https://github.com/drand/drand/pull/1103#discussion_r1088013707
Should these errors be ignored? id := roundID(p.GetRound(), p.GetPreviousSignature()) idx, _ := c.scheme.ThresholdScheme.IndexOf(p.GetPartialSig()) https://github.com/drand/drand/pull/1103#discussion_r1088009704 idx, _ := c.scheme.ThresholdScheme.IndexOf(p.GetPartialSig()) https://github.com/drand/drand/pull/1103#discussion_r1088009954
Could be simplified to `return b.PreviousSig`. _Originally posted by @dlsniper in https://github.com/drand/drand/pull/1103#discussion_r1088005319_ Same for `func (b *Beacon) GetSignature() []byte`
We can regularly see the following issue in our CI tests: ``` server_test.go:194: shouldn't be done. unexpected status: 404 --- FAIL: TestHTTPWaiting ``` To do: - [ ] investigate why...
Most probably this boils down to: - is Kilic working with big endian devices? - are marshaled signatures interoperable or not? - can we build some kind of test for...
We need to investigate and fix all the tests we are currently skipping because of intermittent failures. - [ ] TestClientWithWatcher - [ ] TestStartAndStop - [ ] TestStartWithoutGroup -...