Scarecrow and sprinkler overlays not disposed on exit to title

Open WorstGirl opened this issue 2 years ago • 1 comments

Version: 2.2.9

Problem: The overlays for scarecrow and sprinkler range are not being disposed of when exiting to title, but are still recreated every time a save is loaded.

Result: The overlays keep stacking up each time you load, becoming increasingly opaque until you can't see through them. Only the most recent layer can be disabled in the configuration.

Example:

Clean load 2023_03_11_231127_StardewModdingAPI_65SMRPZGaY

After five reloads 2023_03_11_231248_StardewModdingAPI_imHwZfLGaj

Mar 12 '23 05:03 WorstGirl

Fwiw #315 is a duplicate of this one.

Last time I played I fixed this on a personal fork just by adding the range handler to the handlers to dispose, but I didn't feel comfortable enough with the workings of the mod to PR it since I didn't know if it would mess with anything: https://github.com/Annosz/UIInfoSuite2/compare/master...mmangliers:UIInfoSuite2:master

That said I had no issues with that playthrough after the fix.

Mar 20 '24 23:03 mmangliers