AnnieRuru

wait wait wait ... you mean you really gonna change the type 11 behavior so all our customs has to add `KeepAfterUse` flag ?

then you have to fix `*itemskill` and `*pet` script command as well I just tested firebolt scroll (690) not working after this patch EDIT: yup it fixed ... what a...

if you wanna change the name, there are a few places left https://github.com/HerculesWS/Hercules/blob/master/conf/battle/party.conf#L28 https://github.com/HerculesWS/Hercules/blob/master/src/plugins/db2sql.c#L76 check items ? example ? most item type 11 that not using *itemskill or *pet need...

nope I don't get that error ... how did you apply the code ? manually ? http://stackoverflow.com/questions/6188591/download-github-pull-request-as-unified-diff always download the pull request patch by adding `.diff` on it like this...

really ? I just test one of my script that having setmapflag --> [this one](https://github.com/AnnieRuru/Release/blob/master/scripts/Games%20%26%20Events/Russian%20Roulette/russian_roullette_1.1.txt#L156) works perfectly fine no, the constants you should be looking for, should be https://github.com/HerculesWS/Hercules/blob/stable/doc/constants.md#mapflags and...

yes it read from `db/item_options.conf` but didn't output the constant on `doc/constant.md` https://github.com/HerculesWS/Hercules/blob/stable/doc/constants.md ># Constants > This document contains all the constants available to the script engine. yeah but where...

getitem2/delitem2/countitem2/makeitem2/rentitem2/getitembound2 are already exist in hercules by the way if you don't know what `upstream merge` means, means all these stuffs already implement in rathena ... also means ... we...

because the account ID parameter gets in the way ``` *getitem(, {, }) *getitem2(, , , , , , , , {, }) ``` rathena getitem3 ``` *getitem3 ,,,,,,,,,,,{,}; ```...

> Maybe just have getitem command with item_id and amount which returns inventory idx (or indexes). > and then have other commands setitemoptions? we did tried to make getinventorylistidx a...

because `*getinventorylist` script command ignore the missing index in your inventory just try [my `*getinventorylistidx` script command](http://herc.ws/board/topic/16604-retrieve-inventory-index-getinventorylistidx-delitemidx-equipidx/#comment-90658)