Ankit Pal Singh
Ankit Pal Singh
@zdohnal I simplified the code according to the above suggestions, Please review them. Thank you !
@zdohnal Please review the changes that i made. Thanks! 1. Now the code is using pointer arithmetic, there is no use of index variable. 2. I removed the if-else block...
@zdohnal I resolved the above issues... Now code will also takes care of line like this "--#--something" since this is not an inline comment so it won't get remove. also...
@zdohnal I made the changes as you requested . Please review them, The below is how we are taking care of inline comments now. ``` if ((ptr = strchr(buf, '#'))...
@zdohnal I made the changes as you requested. Please review them.
> @zdohnal I made the changes as you requested. Please review them. @zdohnal Any Update on this ?
> Hi @Ankit3002 , > > have you got time to look into the PR? Yes, I will push the changes today.
@zdohnal Please review the changes that I made ...
> @zdohnal Please review the changes that I made ... @zdohnal Any Update on this ?