pawnft

pawnft copied to clipboard

This is a dope project. ### Ideas: - For development, it'll be good to create some fixture data, e.g loans, accounts so that people can easily test with the UI...

roughpandaz

## Description of Bug It is possible for a user to liquidate the PawnBank contract via the `underwriteLoan` function through a re-entrancy attack. This is caused by line 209: ```solidity...

mrthankyou

Miners with substantial power can prematurely seizure loans

3

## Description of the Bug The PawnBank contract seizeNFT function requires that the the loanCompletionTime be less than the block's timestamp: ``` require(loan.loanCompleteTime < block.timestamp, "Can't seize before expiry."); ```...

mrthankyou

Copying great feedback received via Twitter DMS: **Wilson** - - [x] Gas can be saved during [struct initialization](https://github.com/Anish-Agnihotri/pawnft/blob/master/contracts/contracts/PawnBank.sol#L110-L115), since these values all are already initialized to 0. - [ ]...

Anish-Agnihotri