rollup-plugin-styles icon indicating copy to clipboard operation
rollup-plugin-styles copied to clipboard

Support for rollup v3

Open ghost91- opened this issue 3 years ago • 15 comments

This plugin currently is not compatible with rollup v3, because it requires rollup 2 as a peer dependency:

  "peerDependencies": {
    "rollup": "^2.63.0"
  },

From what I have seen, this plugin mostly seems to work with rollup v3. Probably some more checks need to be done, but possibly, not much more than adjusting the declaration of the peer dependency to something like

  "peerDependencies": {
    "rollup": "^2.63.0 || ^3.0.0"
  },

would be needed.

ghost91- avatar Oct 26 '22 10:10 ghost91-

any ETA? It breaks auto-builds and annoys to do force installs of libs due to this issue.

@Anidetrix are you even OK?

7nik avatar Dec 10 '22 21:12 7nik

any progress?

magnnus avatar Jan 04 '23 05:01 magnnus

I cannot update my directus because of this issue. Is there any workaround?

adanielyan avatar Jan 19 '23 15:01 adanielyan

I would also like to stress the need to add support for rollup v3. Is this package being maintained by anyone? Need to know so I can make decisions. If there is anything that I can do to get this across? are there any limitations for supporting v3? Thank you.

hanorine avatar Feb 06 '23 15:02 hanorine

Looks like @ironkinoko/rollup-plugin-styles is a fork of this repo with rollup v3 support.

https://www.npmjs.com/package/@ironkinoko/rollup-plugin-styles?activeTab=explore

"peerDependencies": {
    "rollup": "^2.63.0 || 3.x"
  },

hanorine avatar Feb 06 '23 17:02 hanorine

Any response would be great! There is a PR ready (#225) but the Owner @Anidetrix does not seem active on GitHub. Maybe a maintainer like @felipecrs can have a look there and help all of us out! Would be really appreciated! 🙇

gregor-mueller avatar Feb 14 '23 09:02 gregor-mueller

+1

cichyadam avatar Feb 16 '23 11:02 cichyadam

Looks there was some movement recently on @Anidetrix account. Perhaps the guy is around after all ;-)?

KenjiTakahashi avatar Mar 31 '23 09:03 KenjiTakahashi

+1

entozoon avatar Jul 11 '23 14:07 entozoon

Why Because alternatives did not look good enough - they are either too basic, too buggy or poorly maintained.

me6iaton avatar Oct 25 '23 16:10 me6iaton

Has anyone found a good alternative in the meantime? It seems like multiple rollup plugins for styles are not working for rollup v4, what are you all using?

rhahne avatar Mar 25 '24 15:03 rhahne

I recently moved my solution to leverage "@dougalg/rollup-plugin-postcss"

  import postcss from '@dougalg/rollup-plugin-postcss';

  // in rollup config plugin section:
   postcss({
      extract: false,
      modules: true,
      use: ['sass'],
    })

hanorine avatar Mar 25 '24 15:03 hanorine

https://github.com/plumelo/rollup-plugin-styler is updated, at least for now.

KenjiTakahashi avatar Mar 25 '24 15:03 KenjiTakahashi

Has anyone found a good alternative in the meantime? It seems like multiple rollup plugins for styles are not working for rollup v4, what are you all using?

In our company we decided to move away from post-css, and avoid third parties as much as posible

dlsaldanas avatar Mar 26 '24 20:03 dlsaldanas

Thanks for your comments. To give an update on my side, we switched the plugin and now use https://github.com/egoist/rollup-plugin-postcss in combination with sass:

 postcss({
      use: [
        ['sass', {
          includePaths: ['./styles', 'node_modules'],
          implementation: sass,
        }]
      ],
      extract: 'styles.css',
    }),

Although this plugin also hasn't been updated in a while, it works on our side and doesn't show any warniing / error messages regarding peer-dependencies.

rhahne avatar Mar 27 '24 09:03 rhahne