rust-tcl
rust-tcl copied to clipboard
AngryLawyer
Wrong signature of function pointers in rust_tcl_sys
For example in rust_tcl_sys::Tcl_CreateCommand you define _proc: *mut Tcl_CmdProc. Tcl_CmdProc is already defined as a function pointer. Thus you define a function that takes a pointer to a function pointer instead of a function that takes a function pointer. This applies to all function taking function pointers.
PS: I think the naming convention would be to call it proc_.
It's come directly out of bindgen, so there may be an issue there. Feel free to fix with a PR :D
I'd prefer not to change the names of anything in rust_tcl_sys, as it's supposed to match the C api as close as possible.
