flutter_flavorizr icon indicating copy to clipboard operation
flutter_flavorizr copied to clipboard

Defining the flavors in a separate config file

Open Petri-Oosthuizen opened this issue 2 years ago • 3 comments

The docs indicate that the flavors should be defined in the pubspec.yaml file. Can this instead be defined in a separate file the same why analysis_options can be defined in the pubspec.yaml and in a separate file?

Petri-Oosthuizen avatar Sep 20 '22 06:09 Petri-Oosthuizen

Hey @Petri-Oosthuizen , can you please elaborate on the reasons to prefer putting the config elsewhere?

AngeloAvv avatar Sep 20 '22 14:09 AngeloAvv

Mainly for separation of concerns. The current project I'm working on might have 10+ flavors and I feel like it'll clutter the pubspec.yaml up quite a bit. The project already has analysis_options.yaml, l10n.yaml and flutter_launcher_icons.yaml (flutter_flavorizr invalidates this one) in the root of the project and I felt like this would fit nicely alongside the other config files.

Great work btw.

Petri-Oosthuizen avatar Sep 20 '22 14:09 Petri-Oosthuizen

This change is pretty disruptive. It should be done in a major release. Particularly difficult to address in the short term.

AngeloAvv avatar Sep 21 '22 05:09 AngeloAvv