Pi-Star_DV_Dash icon indicating copy to clipboard operation
Pi-Star_DV_Dash copied to clipboard

Modifying configuration at all resets APRS for YSF gateway

Open gergles opened this issue 5 years ago • 3 comments

Every time you modify any configuration setting in the UI, APRS reporting is turned back on for the YSF gateway. This appears to be done by this line in configure.php: https://github.com/AndyTaylorTweet/Pi-Star_DV_Dash/blob/c07013616508e12b9ba4dd4ccc800875d233c34d/admin/configure.php#L1751

Could this part of configure.php at least be rewritten to respect the current preference for APRS, rather than forcibly enabling it every time any configuration option is changed? (Ideally... would it possible to have (ideally a hotspot-wide) "enable APRS" toggle somewhere? I don't want my hotspot blasting out its location to the world.)

If you disable the "aprs.fi" option in Expert config, it does stay disabled until you make literally any other config change, then the code listed above re-enables it.

gergles avatar Sep 03 '18 19:09 gergles

Is there a chance to fix this problem because it's annoying every time DMR TG changes into YSF2DMR it's included APRS that we don't want Currently, the problem is in the line https://github.com/AndyTaylorTweet/Pi-Star_DV_Dash/blob/master/admin/configure.php#L2029

sp2ong avatar May 07 '19 05:05 sp2ong

Fixed - no longer modify the state of APRS (on/off) so long as the variable exists.

AndyTaylorTweet avatar May 07 '19 05:05 AndyTaylorTweet

Thank you for your quick reaction. :-)

73 Waldek

sp2ong avatar May 07 '19 08:05 sp2ong