NFCPassportReader icon indicating copy to clipboard operation
NFCPassportReader copied to clipboard

extract.py: Fails for `.ml` files

Open matthiasgeihs opened this issue 1 year ago • 4 comments

First of all: Great project!

I stumbled across a minor bug when reading .ml files with the extract.py script.

https://github.com/AndyQ/NFCPassportReader/blob/84e11ec67a5c0d5ff54f918182fd4658801cc7f2/scripts/extract.py#L29-L42

For .ml files, the variable cns is not set, and hence the script fails at line 37.

matthiasgeihs avatar Feb 15 '24 23:02 matthiasgeihs

Hi @matthiasgeihs Can you give an example of an ml list that fails? (or a location I can get one from?)

AndyQ avatar Feb 29 '24 11:02 AndyQ

If I see it correctly, this fails for all .ml files. Concretely, I was testing with the German CSCA Master List.

matthiasgeihs avatar Feb 29 '24 13:02 matthiasgeihs

I've just fixed this - its in main and will be in the next release

AndyQ avatar Apr 23 '24 14:04 AndyQ

Feel free to close the issue whenever you feel like it. 🙂

matthiasgeihs avatar Apr 24 '24 09:04 matthiasgeihs