Andy Butland
Andy Butland
Hi @PeterKvayt - I'll try to give this a review next week. Before I do though, are you able to update here or on the issue with a practical example...
Hi @PeterKvayt - I've been reviewing this today and think it's looking good. Working as expected when I step through and I've resolved the breaking change and added some unit...
Just wondering if you'd chance to look over my comments and changes please @PeterKvayt , and been able to confirm that with these updates the file upload now functions in...
I'd don't see anything I'm afraid @PeterKvayt - can you point me to them please? Or if they've got lost, re-apply to the conversation on this PR? I'm away for...
No, I can't. They are all marked as "Pending". You'll need to submit the review so I can see your comments.
No problem - thanks for the feedback. As I mentioned, I'll pick up again next week.
I think this is looking good @PeterKvayt - I've replicated all your test cases and can confirm that we now see the expected results. And I've resolved the failing tests...
Just updating that I've found a few issues with blocks in the RTE that we haven't accounted for (checked items are now fixed): - [X] Deleting the content when you...
I believe I've handled the extra cases relating to blocks within the rich text editor now, as detailed in the comment above. @PeterKvayt - would you be up for doing...
Thanks @Migaroez, and thank you @PeterKvayt for initiating and collaborating on this. Merging in now for 16.1,