goron icon indicating copy to clipboard operation
goron copied to clipboard

Fix for Issue #3: Output wrapped in double quotes

Open BenTechCoder opened this issue 3 years ago • 1 comments
trafficstars

Problem: Output CSS file is wrapped in quotes. see Issue #3

Solution: Added exception to remove quotes from echo that creates the css file in Goron but only on Windows machines which is the only place this problem happens

Long-form explanation

ShellJS which is the library Goron uses for shell commands has an echo command for writing files as you would on any Unix-based operating system, and in the Goron code you wrap what you want to echo in quotes.

On Windows machines this causes what gets echoed to be wrapped in quotes. The exact problem mentioned in Issue #3

I forked Goron and made the changes necessary to fix this by adding an exception during file creation in Goron to remove the strings during the echo for Windows machines and keep the strings on every other Operating system.

I've tested this on PowerShell, command prompt, and Windows subsystems for Linux, and it works quite nicely on all.

Thanks for the awesome tool 👍 Best, Ben

BenTechCoder avatar Aug 30 '22 19:08 BenTechCoder

To see the main change directly here's the link to the changes. @hankchizljaw

BenTechCoder avatar Aug 30 '22 19:08 BenTechCoder