sklearn-oblique-tree icon indicating copy to clipboard operation
sklearn-oblique-tree copied to clipboard

Update Cython version

Open tigert1998 opened this issue 2 years ago • 4 comments

tigert1998 avatar May 03 '22 12:05 tigert1998

Would like to test this myself before merging. Will not get to it for a bit though.

AndriyMulyar avatar May 03 '22 14:05 AndriyMulyar

I am using python3.9 from anaconda. I found that I cannot use this repo. After I updated Cython everything went fine. I think more people would use the new version from now on so using the new Cython is urgent.

tigert1998 avatar May 04 '22 08:05 tigert1998

This works for me with python3.9! And when I install in mac, I need to change "malloc.h" to "stdlib.h" and meet lots of "non-void function 'XXX' should return a value" error for the original C code.

But always Restarting kernel... when run the example code...

ZiruiYan avatar May 12 '22 23:05 ZiruiYan

This works for me with python3.9! And when I install in mac, I need to change "malloc.h" to "stdlib.h" and meet lots of "non-void function 'XXX' should return a value" error for the original C code.

But always Restarting kernel... when run the example code...

I took a look at your forked repo. It seems that the original C code does not work well with clang because it uses the behaviour that return means return null.

tigert1998 avatar May 13 '22 08:05 tigert1998