react-json-editor-ajrm
react-json-editor-ajrm copied to clipboard
AndrewRedican
Fix onPaste returing error
When pasting a JSON the component returns this error:
Non-alphanumeric token ' ' is not allowed outside string notation at line 1
I made a fix on onPaste method on line 571:
var text = event.clipboardData.getData('text/plain').replace(/(\r\n|\n|\r|\t|\u200B)/gm, '');
The replace added at the end of that line, remove the undesired characters causing the error.
@AndrewRedican do you still approve PR or follow this project? I can help you on this if you want.
@sOoN92, @AndrewRedican might not be accepting this PR because it includes code to delete most of README.md and updates package-lock.json, etc. Perhaps you should cut it back to just the one line change in src/index.js.
@sOoN92, @AndrewRedican might not be accepting this PR because it includes code to delete most of README.md and updates package-lock.json, etc. Perhaps you should cut it back to just the one line change in src/index.js.
Fixed.
@sOoN92 are you sure of your fix ? Tested on my side and still had the error.
@jlopvet I'm pretty sure, I don't have the error anymore. Can you share the test steps?
@sOoN92 changed line 636 to var text = event.clipboardData.getData('text/plain').replace(/(\r\n|\n|\r|\t)/gm, ''); Relaunched my dev server, pasted some json (with double quoted keys) and same error.
@jlopvet can you share the test you made, so I can double-check it?
FYI @AndrewRedican
I updated the PR, can you check it again please @jlopvet ?
FYI @oliverbock @AndrewRedican
Guys can you please check the pr again? @oliverbock @AndrewRedican @jlopvet ?
