Andrew Nolte

^ I was able to fix the copyright by putting it test_regress/t/ actually

@wsnyder I think this PR is good to go, as well as https://github.com/verilator/verilator/pull/4913 and https://github.com/verilator/verilator/pull/4918 on the stack. Apologies for the delay last week, I was out of town

I guess --xrun isn't being run in CI because that would fail, do I need to do something to get --iv to run in CI?

@wsnyder @marlonjames I tried fixing this in src/V3LinkResolve.cpp by marking AstNodeModules as public if a child module was public, but this didn't work (after VL_RESTORER restored m_modp) on both visitors....

It looks like the issue is that in Vt_vpi_dump_035_scope.tree it emits the scope with a dot instead of __DOT__ ```1:2: SCOPE (MKB) {e150ai} TOP.t.cond_scope__DOT__sub_wrap_gen.my_sub [abovep=(QBB)] [cellp=(KM)] [modp=(VE)]``` which makes varHierarchyScopes...

Actually I think I see the pattern now of using "." to separate modules, and __dot__ for internal scopes, so it should remain a period. It's just a coincidence that...

I actually found another edge case, so I'll try to fix that on this PR as well

This one seems a bit trickier to debug, I separated it and put it here @wsnyder https://github.com/AndrewNolte/verilator/pull/1

This should be ready now as well

Ready to merge! @wsnyder