django-extra-views icon indicating copy to clipboard operation
django-extra-views copied to clipboard

setting “python_requires” with ">=3.5" is a better way to declare Python compatibility

Open PyVCEchecker opened this issue 3 years ago • 1 comments

Hello! I notice that the dependency of this distribution

install_requires=["Django >=2.1"]

I found that Django>=2.1 requires Python>=3.5 , and you declare supported python:3.5+ in README. I guess you want to set python>=3.5. But I think it is a better way to declare Python compatibility by using the keyword argument python_requires than declaring that in README.rst:

  • Descriptions in python_requires will be reflected in the metadata
  • “pip install” can check such metadata on the fly during distribution selection , and prevent from downloading and installing the incompatible package versions.
  • If the user does not specify any version constraint, pip can automatically choose the latest compatible package version for users.

Way to improve: modify setup() in setup.py, add python_requires keyword argument:

setup(…
     python_requires=">=3.5",
     …)

Thanks for your attention. Best regrads, PyVCEchecker

PyVCEchecker avatar Oct 27 '22 06:10 PyVCEchecker

Thanks, can you create a PR?

jonashaag avatar Oct 27 '22 07:10 jonashaag