Andrew Gaspar

Results 38 comments of Andrew Gaspar

> > Take one last look? > > One more idea I had concerning usability: Maybe we should make `EquivalenceFromAnyBytes` a sub trait of `Equivalence` as it really only makes...

@adamreichold Sorry I haven't checked in on this in awhile - I've been going through a long interview process with a few different companies, and haven't had much free time....

Hm... defining Scope for pinned LocalScope isn't actually sound and I'm not sure why I thought it was. Marking as WIP. I think the macro is fine, but trying to...

Requires #84 to pass CI.

> Injecting an unsafe block into user code could also unfavorably interact with things like #![deny(unsafe)] AFAIU. Should be fixable with an `#[allow(unsafe)]`, right? > To be honest, the macro-based...

What limitation in pre-C++17 stops visit from taking the arguments as non-const lvalue references?

Oh, I suppose even with C++11, using just plain lvalue references would prevent you from using visit with temporaries, since temporaries can't be passed as a non-const reference... I suppose...

> I can also help with review and maintenance, as I'm relying on corrosion in a project. A very successful project as far as I can tell. :) You've been...

Note that this won't help with Ninja generators at all - only generators which don't support `BYPRODUCTS`.

Roughly, you'll need to do some updates to [`_add_cargo_build`](https://github.com/AndrewGaspar/corrosion/blob/bf3af38e4f404525af92c381fe81394617b67087/cmake/Corrosion.cmake#L64) - You'll need to add a `${CMAKE_COMMAND} -E copy` call in the `add_custom_target` call towards the end of the function to...