Andrew Dryga

Results 248 comments of Andrew Dryga

@jamilbk it doesn't break but I agree this is one of the busiest tables. The most overloaded here is the group list. We already have an issue turning that into...

@jamilbk everything that is left is your approval :)

@jamilbk Is it better now? Implemented https://github.com/firezone/firezone/issues/6742 and resized the columns. The seeds are now both more realistic and more random.

@bmanifold do you want to take care of the changes in providers you implemented or should I do that?

I don't have a ton of time to check how the source code has changed in a year I'm not at Firezone, but if the architecture remained the same (we...

Hello @PragTob, Indeed this is a hard tradeoff, I think we might drop `String` checks but still will need to iterate over the struct because our goal is basically to...

@ruslandoga teah, the older package version did this but the performance benefit is negligible and, as I remember, you can't use it with anything that contains an unescaped value.

I've removed the use of `String.valid?/1`, and the performance is ~50% better, only ~35% more expensive than Jason encoding itself (OTP 27). Thanks @josevalim ❤. Before: ``` Comparison: just Jason...

You should check the settings on the Stripe end. As long as the limit is not set then the count will not be enforced in Firezone: https://github.com/firezone/firezone/blob/main/elixir/apps/domain/test/domain/billing_test.exs#L91

I believe that Stripe allows you to configure this behaviour for the billing portal (required fields per plan), and nothing needs to be done on the Firezone end.