Andrew Barba
Andrew Barba
No problem @Lukasa hope you enjoyed! I addressed your comments, ready for another round of review.
@Lukasa Hope you had a great WWDC week, I just pushed up first go at a new extension change object. Let me know what you think
@Lukasa Friendly nudge to keep this moving. Let me know what I can tackle next
@Lukasa I'm having problems getting CI to pass, it's failing to compile with a `fatalError` but no details reported. Everything builds and tests pass locally
Thanks @Lukasa I think this is ready for another review.
You're exporting `ApnNotifyService` which means you are probably creating a bunch of instances of this class which you should not do. You should only create a single instance of the...
Yes absolutely. Creating one instance per team is what you want. The tokens will be managed inside each instance and as long as you don't keep creating those instances over...
I believe the http2 API only supports a signing key (JWT). Do you have docs saying otherwise? This package exclusively uses the new http2 API and I don't want to...
Interesting, looking into this. Are you using TypeScript or JavaScript? It seems like notification constructor is not working correctly, it should always have a default `options` property which is where...
And you're using the latest version right? v11.7.0?