Andrew S. Rosen

Results 101 comments of Andrew S. Rosen

Thanks for the reply. I will chat with folks here to see how we can get a new version released. This PR can probably be closed thereafter.

No, generally new releases are not submitted to JOSS. The short manuscript that goes alongside the code should describe the overall structure of the package and its purpose, which generally...

Got it, thanks for the info and prompt reply!

Hi @fraricci --- thanks for the ping and apologies about any issues. It looks like the change was made in [this PR](https://github.com/materialsproject/pymatgen/pull/2388) based on [this issue](https://github.com/materialsproject/pymatgen/issues/2384). I will look into...

I also would love to see `black .` applied to the repo, but I will `black` just about anything...

Hi @kyleniemeyer! Unfortunately, I'm unavailable at this time, but thank you for considering me as a reviewer.

Ah, my mistake! I misread the instructions. For some reason, I thought you meant your fork was a refactor of the original. Oops...! Thanks!

In hindsight, you were pretty clear. I just am over-eager in forking everything and then forked `main` by default instead. 😅

Closed this prematurely. I did `pip install git+https://github.com/kjappelbaum/molecule-tda.git@refactor` and got the following. I can try in a "genuine" Linux environment. ``` Building wheel for diode (setup.py) ... error ERROR: Command...

It's all good! That's part of the process :) Maybe one step closer? This is what I get after installing `cgal`. ``` Building wheel for moltda (pyproject.toml) ... done Created...