Andrew-Cottrell

Results 28 comments of Andrew-Cottrell

For https://github.com/bfintal/Counter-Up2/releases/tag/v1.0.1, extract the `dist/index.js` file (ECMAScript 5 compatible), rename to `counterup2-1.0.1.min.js`, and use the following ```javascript jQuery(function ($) { // using failsafe $ alias here, see https://api.jquery.com/jQuery/#jQuery3 "use strict";...

@jkdoyle Did you see any error in the console? Does `window.counterUp` look like the following? > console.dir(window.counterUp) ▼ Module decimalPlaces: (...) ▶ default: ƒ (t) divideNumbers: (...) hasComma: (...) isFloat:...

@yargohor > Hi Andrew. Does your library work with jquery 3+? It is **not** my library; I merely commented above how I used `Counter-Up2` with [jQuery](https://jquery.com/). `Counter-Up2` does appear to...

> can I include Waypoints.js? @markcnunes has kindly [provided an example with Waypoint](#issuecomment-519060694).

One way forward would be to take advantage of the _point_ vs _value_ naming inconsistency. `goog.math.Range.containsPoint` could be documented as using the closed interval interpretation. A new `goog.math.Range.containsValue` function could...

> Range has a number of issues - for instance, its constructor allows passing numbers in either order, so it's kind of fundamentally closed. For functions that take two arguments,...

>Guava has been quite successful with named factories for ranges: Range.closed(1, 3), Range.closedOpen(2, 4), Range.lessThan(5), Range.atLeast(6), etc. Simply accepting an inclusive and exclusive parameter and allowing either order seems like...

I often find running `closure-compiler` with this argument helps highlight issues with type resolution. --jscomp_warning=reportUnknownTypes

To clarify, I am suggesting to periodically use `reportUnknownTypes` and to only examine the warnings for the script or type you are currently focused on. I am not recommending you...

Off topic & FYI: if the Closure Compiler `@language_out ECMASCRIPT_2015` option is specified ```javascript // ==ClosureCompiler== // @compilation_level ADVANCED_OPTIMIZATIONS // @output_file_name default.js // @language_out ECMASCRIPT_2015 // @formatting pretty_print // ==/ClosureCompiler==...