Andrew Chen Wang

Results 430 comments of Andrew Chen Wang

@Enchufa2 I'm unable to reproduce this error in both redis main/master branch and aioredis==2.0.0. https://github.com/Andrew-Chen-Wang/aioredis-issue-778 unlike `ss`, I'm using `CLIENT KILL` and `CLIENT KILL ADDR` with no success. When doing...

@cjdsellers I still can't reproduce this issue, so a PR is much appreciated as we're down a maintainer now and I'm stuck with work.

Tracking https://github.com/redis/redis-py/issues/1789

@wodny we are currently refactoring to be more up to date with redis-py. Sorry for the delay. I should have time this week as school starts up again.

Heads up #1156 will be merged soon. It should fix your `core.Commands` mixin. I would love some help with #1267 to be more up to date with Redis. I have...

They don't work. We're still speculating how to do the locks properly since there was a debate on whether aredis's lock was correct. But aredis's lock does uhh functionally work...

@abrookins I can probably do it over the weekend. In general to stay up to date with redis-py, should I make one PR with multiple commits or several PRs (reflecting...

tl;dr Justification for why only `rediss` was hard coded: https://github.com/redis/redis-py/pull/446#issuecomment-42906656 --- SSLConnection was implemented in 2014: - This shows when the class was added: https://github.com/redis/redis-py/commit/de0004b03a04ea2884a06a074a3d382ea8b08a57#diff-45b6ba995a827b484d3ef97cb806d336bf058ff9678b04cf371200ea53e584d0 - This shows when we...

Given https://github.com/aio-libs/aioredis-py/issues/1209#issuecomment-974673630, to be as close to redis-py as possible, you should file an issue in the redis-py repo to see if they'd be willing to make the change (especially...

Thanks for letting me know @chayim! I'll wait for https://github.com/redis/redis-py/issues/1767 for this change; we're also a little behind on getting on par with redis 4.0.0 😅