Andrew Chen Wang

Results 430 comments of Andrew Chen Wang

lol @vinipsmaker yours is definitely more right than my guesses :D Very cool concepts!

@Veritaris check if this helps: https://github.com/pydanny/cached-property#working-with-asyncawait-python-35

Thanks for the report! PR #1207 created

@skhayrulin this might be your problem? ``` File "redis_conn.py", line 17, in run await asyncio.gather([task_1, task_2, task_3]) ``` Instead, pass in ``task_1, task_2, task_3`` or do ``*[...]``

@linux2000in are you using aioredis 1.3.1 or aioredis 2.0.0b1? We do not support aioredis 1.3.1 at all anymore.

Unfortunately, the latest "stable" version is actually in beta, version 2.0.0b1, which we released yesterday. For aioredis==1.3.1, I have no idea why it's causing issues as the changelog for redis...

In the meantime, take a look at this to see if it helps: https://github.com/aio-libs/aioredis-py/issues/409#issuecomment-399094609

@djstein Are you getting this on production? If you're experiencing this in development, please refer to #930 for migration needs as v1 major version will not get any fixes.

@Enchufa2 thanks for running the test. What do you mean automagically? Is there code that they implement that we somehow missed or code that we did port that is not...

@Enchufa2 can you change this: https://github.com/aio-libs/aioredis-py/blob/dbdd0add63f986f2ed2d56c9736303d133add23c/aioredis/connection.py#L850 to `if not self.is_connected:` Redis is checking using `self._sock`, but we don't use `self._sock`. This could be the underlying reason, though I'm not sure...