Andrew Chen Wang

Results 430 comments of Andrew Chen Wang

@mahyard Django 3.2 is fully supported; no tests failed: https://github.com/Andrew-Chen-Wang/django-ratelimit/actions/runs/1163763411

👍 One more thing to note. Django has deprecated python-memcached in favor of a the pylibmc. @jsocol do you want me to test both packages as seen here https://github.com/noripyt/django-cachalot or...

You can take a look at a comparison made by Pinterest here: https://github.com/pinterest/pymemcache#comparison-with-other-libraries In other words, we'll be testing on two backends: pylibmc (yes you're guess was right; it's the...

All memcache backends are now tested. pymemcache having some issues. Seems like it only doubled due to the replacement of a backend rather than an addition. Not sure what to...

@jsocol Memcached is failing on pymemcache (python-memcached's replacement) and pylibmc. A solution for now is that memcached support for the CacheFail tests are simply ignored if not using python-memcached since...

@mahyard apologies. Beginning of school. Will have much less time. Based on my past PRs, having a direct dependency was a no-no. Though we could do a broad exception and...

@jsocol Ah sorry, I was thinking about making `django_ratelimit.exceptions` do a try/except clause: ```python from django.core.exceptions import PermissionDenied try: from rest_framework.exceptions import Throttled class Ratelimited(PermissionDenied, Throttled): ... except ImportError: class...

Temporarily you can try this: https://stackoverflow.com/a/58726299 But the only solution for the package itself is to not use dictionary based settings. That'd require a new major version. Thing is; for...

I think adding a signal for something scalable like notifications would be potentially harmful. Over at djangorestframework-simplejwt, I considered the same problem and came to the conclusion that we could...

Just some further thoughts from [my post in the developer group thread for DATABASES setting for async usage](https://groups.google.com/g/django-developers/c/V5ONhY5Nun0): ping @andrewgodwin if you have any thoughts on this (or if you're...