Wyrmsun icon indicating copy to clipboard operation
Wyrmsun copied to clipboard

Translatable Quest Objective

Open BeWorld2018 opened this issue 6 years ago • 26 comments

2018-04-10_10h28_54

On this example, on top left, somes texts arent translatable, can you fix it ? thanks

https://github.com/Andrettin/Wyrmsun/blob/master/scripts/civilizations/dwarf/quests_the_first_dwarves.lua

BeWorld2018 avatar Apr 10 '18 08:04 BeWorld2018

image

Same here, Hits on stratagus.lua

thanks you :-)

BeWorld2018 avatar Apr 10 '18 08:04 BeWorld2018

in guichan.lua , this label is not translatable

menu:addLabel("~<Single Player Game Setup~>", offx + 640/2 + 12, offy + 72)

I have a bug when French language is selected in Single Player Setup 👍 image

I dont have choice Humand civilization.

BeWorld2018 avatar Apr 10 '18 09:04 BeWorld2018

Thanks for the bug reports :)

I've fixed the first issue now: https://github.com/Andrettin/Wyrmgus/commit/68709cbf197e133df396f20441bf472758d5e5fb

Regarding the second one, that string should already be translatable. In the Tip function, both the name and description of the tip are set to be translatable strings.

About the third issue, I'm looking into it right now.

Andrettin avatar Apr 10 '18 17:04 Andrettin

Again me :-) i see a lot of dynamical string in cpp code for example: https://github.com/Andrettin/Wyrmgus/blob/master/src/action/action_build.cpp line 218: _("%s cannot reach building place") of line 313: _("Not enough resources to build %s")

It's possible to fix that because impossible to translate this :( A lot of work..... sorry

BeWorld2018 avatar Apr 10 '18 17:04 BeWorld2018

Fixed the third issue: https://github.com/Andrettin/Wyrmgus/commit/df549ee059c41c72aabe6eee85f210d54adceeec https://github.com/Andrettin/Wyrmsun/commit/3bee68606172fe6eafb52923ced800078fd4ee27

Andrettin avatar Apr 10 '18 17:04 Andrettin

About the dynamic strings, they are translated before the dynamic part is replaced, so they shouldn't be any more work to translate than other strings. I've added an example of translating them in the Portuguese translation:

msgid "Not enough resources to build %s" msgstr "Faltam recursos para construir %s"

Andrettin avatar Apr 10 '18 18:04 Andrettin

ok, cool i test it. My french's file is bigger : 250 Kb and i am not finished. I continue to post here if i found bug or mistake, thank

BeWorld2018 avatar Apr 10 '18 18:04 BeWorld2018

Alright :)

Andrettin avatar Apr 10 '18 18:04 Andrettin

hi!

in scripts/menus/save.lua line 21 "Saved game to: " Can you fix _(" ?

BeWorld2018 avatar Apr 11 '18 08:04 BeWorld2018

ARff.. my last save game.. doesnt work. The game close when i load this saved game game.sav.gz

BeWorld2018 avatar Apr 11 '18 08:04 BeWorld2018

Fixed both now :) All strings in save.lua are now translatable, and the save game now loads correctly.

Andrettin avatar Apr 11 '18 16:04 Andrettin

You are the Boss :-)

BeWorld2018 avatar Apr 11 '18 17:04 BeWorld2018

Hehe, thank you :)

Andrettin avatar Apr 11 '18 18:04 Andrettin

ARhhh. i downlmoad master wyrmsun on Windows.... (with wyrmgus 3.3.1)

At startup

[string "scripts/civilizations/norse/factions.lua"]:234: bad argument #-1 to 'DefineFaction' (number expected, got table) stack traceback: [C]: in function 'DefineFaction' [string "scripts/civilizations/norse/factions.lua"]:234: in main chunk [C]: in function 'Load' [string "scripts/factions.lua"]:63: in main chunk [C]: in function 'Load' [string "scripts/civilizations.lua"]:3858: in main chunk [C]: in function 'Load' [string "scripts/stratagus.lua"]:1867: in main chunk

BeWorld2018 avatar Apr 11 '18 18:04 BeWorld2018

where i can find the last wyrmsun.exe for Windows ?

BeWorld2018 avatar Apr 11 '18 18:04 BeWorld2018

Here you are: wyrmsun.zip

Andrettin avatar Apr 11 '18 18:04 Andrettin

Thanks

BeWorld2018 avatar Apr 12 '18 08:04 BeWorld2018

Can you help me, when i chosse french language, i have a 1 bug: when i choose Earth in Player solo Menu, i dont have map and title has not translate

image

wyr-fr.zip

Thanks you :-) You can publish french, i continue on it, i dont finish

BeWorld2018 avatar Apr 13 '18 15:04 BeWorld2018

I've fixed it now, thanks for informing me of the problem (and for providing the updated translation!) :)

I've likewise added the updated translation now to the repository.

What do you mean by publishing the French translation? Making it available through the options menu?

Andrettin avatar Apr 13 '18 16:04 Andrettin

thanks !! No just update reposity.

BeWorld2018 avatar Apr 13 '18 16:04 BeWorld2018

Ok, already done :)

Andrettin avatar Apr 13 '18 17:04 Andrettin

I've also updated some of the hotkey markings in the French translation: https://github.com/Andrettin/Wyrmsun/commit/ac1e81fdac771d13723418dd5660d95c172c8780

Andrettin avatar Apr 13 '18 17:04 Andrettin

Hi ! Little update for French translate, thanks wyr-fr.zip

BeWorld2018 avatar Dec 26 '18 19:12 BeWorld2018

Thank you! I've added the updated translation now :)

Andrettin avatar Dec 26 '18 20:12 Andrettin

Another update :-)

wyr-fr.zip

BeWorld2018 avatar Dec 31 '18 07:12 BeWorld2018

Thank you! I've committed the updated translations to the repository: https://github.com/Andrettin/Wyrmsun/commit/3993fdcedaafe1f5fdc1065608b093dd8a20f8a1

Andrettin avatar Dec 31 '18 09:12 Andrettin