BulletSharpPInvoke icon indicating copy to clipboard operation
BulletSharpPInvoke copied to clipboard

OverlapFilterCallback should be abstract

Open zdimension opened this issue 8 years ago • 3 comments

zdimension avatar Dec 03 '16 23:12 zdimension

Echoing this. The NeedsBroadphaseCollision method is also not virtual. Please fix this.

Edit: Also, the Bullet manual suggests overriding btCollisionDispatcher for virtual methods needsCollision(), needsResponse, and dispatchAllCollisionPairs. I don't see virtual methods for any of these in C#.

Could you please verify that those things that should be override-able are properly exposed?

Inverness avatar Feb 16 '17 01:02 Inverness

Done in https://github.com/AndresTraks/BulletSharpPInvoke/commit/99d1738431d67334aaffe5ba336535152b3242e0.

AndresTraks avatar Mar 11 '17 17:03 AndresTraks

CollisionDispatcher will take some more time. Making C++ classes inheritable in C# is not very straight-forward.

AndresTraks avatar Mar 12 '17 12:03 AndresTraks