AvePurchaseButton icon indicating copy to clipboard operation
AvePurchaseButton copied to clipboard

Published 20 hours ago • verified publisher icon AndreasVerhoeven

Carthage Support

Open swemoney opened this issue 7 years ago • 5 comments

Any chance of seeing Carthage support added?

swemoney avatar Apr 11 '17 02:04 swemoney

Isn't Carthage not meant for dynamic frameworks, instead of small components?

AndreasVerhoeven avatar Apr 11 '17 07:04 AndreasVerhoeven

I could be wrong, but to me, Carthage is just a more transparent CocoaPods. Just instead of compiling everything into a single Pods framework, it compiles them all separately. Neither is super necessary for something as small as this since it's easy to just manually use the source but I don't see the harm in adding Carthage support since CocoaPods is already supported.

swemoney avatar Apr 11 '17 08:04 swemoney

I'm happy to add Carthage support, but I have no idea on how to do that, other than creating a fully dynamic framework. I think making this into a framework is a bit too much.

If you have any better ideas, please hook me up with a link on how to do so or send me a PR :)

AndreasVerhoeven avatar Apr 11 '17 09:04 AndreasVerhoeven

No problems. I'm actually completely new to adding Carthage support too. If I get some free time, I'll see if I can't figure out how to add it and send a PR your way.

swemoney avatar Apr 11 '17 09:04 swemoney

Awesome, thank you!

AndreasVerhoeven avatar Apr 11 '17 09:04 AndreasVerhoeven