Andreas Allacher

Results 149 comments of Andreas Allacher

I think npm install would also work for plugins. it should be fine as long as a package-lock is provided.

@shyim @seggewiss Shall I create a PR to use install in build-administration / build-storefront for plugins and storefront / administration instead of npm clean-install? In which case I would also...

@shyim @seggewiss I have done some testing and the fastest solution by far is to not do any npm install or clean-isntall, if it isn't necessary. So independently from using...

@mzeis From what I know, could be wrong though as `npm` is not really my expertise: 1. `npm install` does take the `package-lock.json` into account. - It might be updated...

@mzeis Should hopefully have been only due to some version changes in the package.json, see also: https://dev.to/saurabhdaware/but-what-the-hell-is-package-lock-json-b04 However, to be honest I really think npm is in general weird how...

Might be the case, however that expression is especially useful for adding additional CSS classes, which is why it would be really nice if it supports strings too.

In that case I would think the syntax should at least be modified to not support "fix" strings. One can use the alias ViewHelper to make values out of those...

Ok. Great. I am happy with removing not correctly working fix completely as long as they don't work at all and it is clear they are not supposed to work...

Hi @ezimuel if you still support 7.x you do use it https://github.com/elastic/elasticsearch-php/blob/v7.17.0/src/Elasticsearch/ClientBuilder.php#L640 and you do not check `$_SERVER` and/or `$_ENV`, so `putenv` would be necessary to change it using symfony/dotenv....

@ezimuel No problem. I think you can could probably leave getenv to query as a last resort but I think checking `$_SERVER['ELASTIC_CLIENT_APIVERSIONING'] ?? $_ENV['ELASTIC_CLIENT_APIVERSIONING']` should be enough and would be...