Shirly

Results 23 comments of Shirly

I think this PR https://github.com/tikv/tikv/pull/18096 fix it?

So here we create an new thread `snap-gen-worker` to send `Task::Gen` to `snapshot-generator`? I think for the snapshot part, it is already a disaster for we maintainers, we already have...

Good job, I see. so here we just move schedule job of `Task::Gen` from `region-worker` to `snap-generator` thread pool? This should LGTM then. Meanwhile,I was mislead by the PR description...

seems similar with https://github.com/tikv/tikv/issues/15800

> Is there any performance number to comprare these two methods? Comparison of bench test results between current PR and master branches: current branch: ``` ➜ iceberg-rust git:(convert_arrow_filed_to_iceberg_field) ✗ cargo...

> Also please note that ArrowSchemaVisitor is a framework for processing ArrowSchema in visitor pattern, not only designed for iceberg schema converter. We will use it later when processing parquet...

> I think it's an expected behavior? Yes, but the scenarios mentioned in the issue are indeed real and we need to consider addressing this issue. I think one simpler...

https://github.com/tikv/pd/blob/056e04c3e3a33a9d34e94dbcda802b5740bc510f/pkg/schedule/operator/builder.go#L660-L685 at L663, the store IDs(peersMap.ids()) are sorted in ascending order.As a result, when selecting a target store for leader transfer, among all stores that meet the eligibility criteria, the...