André Caron

Results 37 comments of André Caron

Hi Will, Thanks for your very thorough feedback! As you can tell from the commit dates, it's been about 3.5 years since I wrote this and reviewing any changes or...

> That would slow it down for everyone. I know that calling `.setdefault()` for cases where the key is already in the dict usually has noticeable overhead, but that's mostly...

I like where this is going! I played around a bit with a cache_property desriptor and `__slots__` today only to realize what the absence of `__dict__` really means... (hint: it...

@jayd3e Are there any perceivable effects of adding the child node? For instance, if I use this to sort numbers, will it still work as is and sort numbers or...

> If you are using it to sort numbers/characters, then would need to make that validator a preparer, as it wouldn't actually change key if its a validator, it would...

@bessbd I took a quick look. I'm not familiar with Java and the ecosystem in this project, but it looks to me like some kind of static code analysis tool...

@bessbd Now that the build is fixed, I rebased this onto the latest trunk to get a clean build :-)

Before merging, I will also set the `spotbugs.maxAllowedViolations` property to 0.

@bessbd @mpercy I rebased this and set `spotbugs.maxAllowedViolations=0`. I have some more changes to fix PMD violations as well. Do you want those in a new commit on the same...

I've hacked a workaround in AndreLouisCaron/httpxx@608af01eee7cfdad579381f61edf70778eedaa58, but it's really ugly. I have to manually fix off-by-one errors because of this bug, and the count is unreliable until the `on_message_complete()` callback...