Mateusz Burzyński
Mateusz Burzyński
The conflicts are also already resolved [here](https://github.com/microsoft/TypeScript/pull/54668), so to resolve them u can just merge it into this one.
> Wait, this is Ron’s PR. I was thinking this was @Andarist’s PR. Well, it could have been my PR - if this PR would be a code review comment/request...
@rbuckton did u check the PR in which i resolved the conflicts ( https://github.com/microsoft/TypeScript/pull/54668 )? Iirc i already fixed it there but it has been a while so my memory...
> That PR lists 5000+ file changes and is too large for GitHub to render in the UI, so I'm not sure what changes you may have made. We can...
That's interesting! It turns out that for this one test the `wildcardType` used in place of a blocked string performed better. I had to replace it with `blockedStringType` just 4...
> I had to make other changes than what you've illustrated to get the expectations from the tests I added to pass, reverting a number of places where CheckMode.IsForStringLiteralArgumentCompletions was...
@weswigham since partial inference by default seems to be to be off the table - do you envision any way for library authors to opt-into that in the future in...
@devanshj the available options are listed [here](https://github.com/microsoft/TypeScript/blob/12718ad88e0edbf59e7ca401e3db8ae6a05f4c2a/CONTRIBUTING.md#running-the-tests). I usually just run this: ```bash hereby runtests --tests=myTest --no-lint ```
It seems that unit tests are somewhat special and they might run conditionally. I found some things related to that in [this file](https://github.com/microsoft/TypeScript/blob/12718ad88e0edbf59e7ca401e3db8ae6a05f4c2a/src/testRunner/runner.ts#L145) - but I wasn't able to quickly...
I was just about to report the same issue (my repro case can be found [here](https://stackblitz.com/edit/react-ts-tjuru8?file=App.tsx,Page2.tsx,Page1.tsx), it's prepared based on @jmca's repro for [the issue](https://github.com/emotion-js/emotion/issues/3038) caused by this - but...